Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clojure-deps-edn] Create Pull Request template to guide contributions #50

Closed
practicalli-johnny opened this issue Jun 18, 2022 · 0 comments · Fixed by #69
Closed

[clojure-deps-edn] Create Pull Request template to guide contributions #50

practicalli-johnny opened this issue Jun 18, 2022 · 0 comments · Fixed by #69
Assignees

Comments

@practicalli-johnny
Copy link
Contributor

Please raise an issue before raising a pull request in order to avoid working on something that would not be accepted.

Sweeping changes to this repository (or any open source project) are less likely to be accepted and take longer to review and test by the maintainers.

For example, updating a number of different libraries all at once will require a lot of manual testing to ensure each alias still works, especially with some of the recent changes in the ClojureScript library.

Pull requests that change deprecated aliases will be rejected. Those aliases are to be removed, so no further testing will be done. Updating deprecated aliases does not demonstrate an understanding of the project concerns.

@practicalli-johnny practicalli-johnny changed the title Create Pull Request template to guide contributions to this project [clojure-deps-edn] Create Pull Request template to guide contributions Jun 18, 2022
@practicalli-johnny practicalli-johnny self-assigned this Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant