Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portal issues with React v16 #10

Closed
amertak opened this issue Jul 27, 2017 · 3 comments
Closed

Portal issues with React v16 #10

amertak opened this issue Jul 27, 2017 · 3 comments

Comments

@amertak
Copy link
Contributor

amertak commented Jul 27, 2017

As stated in facebook/react#8386 and also tested with alpha versions, this library is not working with new React Core.

Putting it here as facebook/react#8386 gives a solution :)
Will definitely work on pull request to make this library work with old and new React core.
@pradel
Copy link
Owner

pradel commented Jul 28, 2017

That could be really cool thanks!

@amertak
Copy link
Contributor Author

amertak commented Jul 31, 2017

#11

Basic idea, its working for old and new react.

@amertak amertak mentioned this issue Aug 4, 2017
Merged
@pradel pradel closed this as completed in #11 Aug 4, 2017
@pradel
Copy link
Owner

pradel commented Aug 4, 2017

Published as 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amertak @pradel