This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
Add simple client for sending messages to the Go HTTP API. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat make API requests in case the TestSession is accidentally not used.
|
Ready for review. |
| auth = (self.account_key, self.conversation_token) | ||
| data = json.dumps(py_data) | ||
| r = self.session.put(url, auth=auth, data=data, headers=headers) | ||
| r.raise_for_status() |
There was a problem hiding this comment.
Are we just expecting Sentry to catch all these?
There was a problem hiding this comment.
Not entirely sure what the question is suggesting? Would it be preferred to have custom exception classes?
There was a problem hiding this comment.
No I guess not with your API as you should only get error codes for genuine errors so the consuming client should decide what to do with the raised exception.
There was a problem hiding this comment.
Requests seems to raise these all nicely as HTTPError and I think that makes sense here.
|
Ready for re-review. |
|
I can't see anything else, looks good to me 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.