Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

add UI for the webhook token #63

Merged
merged 3 commits into from
Mar 18, 2016

Conversation

miltontony
Copy link

No description provided.

@miltontony miltontony self-assigned this Mar 18, 2016
@miltontony
Copy link
Author

@jerith @smn ready for review

}
return s4() + s4() + '-' + s4() + '-' + s4() + '-' +
s4() + '-' + s4() + s4() + s4();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't technically a valid UUID (see https://en.wikipedia.org/wiki/Universally_unique_identifier#Version_4_.28random.29 for the bits that specify variant and version), but that doesn't really matter much for our purposes unless Django actually validates that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerith yup, django doesn't care. It only expects a 32 char string really

@jerith
Copy link
Member

jerith commented Mar 18, 2016

👍 assuming Django's okay with potentially "invalid" UUIDs.

miltontony added a commit that referenced this pull request Mar 18, 2016
…webhook-token

add UI for the webhook token
@miltontony miltontony merged commit 8f35d8b into develop Mar 18, 2016
@miltontony miltontony deleted the feature/issue-63-add-UI-for-the-webhook-token branch March 18, 2016 18:25
@@ -284,7 +284,6 @@ def abspath(*args):
}
DEBUG_TOOLBAR_PATCH_SETTINGS = False

SOCIAL_AUTH_SESSION_EXPIRATION = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants