This repository has been archived by the owner on Feb 13, 2022. It is now read-only.
remove showing surveys entries for specific groups #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sewagodimo
approved these changes
Jun 6, 2018
smarzban
force-pushed
the
remove-construct_main_menu
branch
from
4a7b015
to
c0a6bf7
Compare
|
@saeedmb8 this might be problematic for projects like TuneMe where these groups still exist and might make use of this functionality. Perhaps there could be a better way to solve this problem? |
|
@codiebeulaine we should have removed this while back, since we introduced the group permissions that has been added as a permission to a group. |
|
okay, worried that code is being removed and tests are not failing :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.