Skip to content
This repository has been archived by the owner on Feb 13, 2022. It is now read-only.

add homepage introduction field (BED) #92

Merged
merged 5 commits into from
Feb 13, 2018
Merged

add homepage introduction field (BED) #92

merged 5 commits into from
Feb 13, 2018

Conversation

codiebeulaine
Copy link
Contributor

@codiebeulaine codiebeulaine commented Feb 12, 2018 •
edited
Loading

No description provided.

@Mitso
Copy link
Contributor

Mitso commented Feb 13, 2018

@codiebeulaine looks great to me.
🍰 🍰 🍰 👍

@alexmuller
Copy link
Contributor

The file 0025_add homepage introduction.py should probably have underscores instead of spaces to be consistent with the other migrations. I think the spaces would be ok but not totally sure what will happen when it runs in production.

alexmuller
alexmuller approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@alexmuller alexmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and runs ok for me 👍

@codiebeulaine codiebeulaine merged commit e2a336c into develop Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexmuller alexmuller alexmuller approved these changes

@Mitso Mitso Mitso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codiebeulaine @Mitso @alexmuller