Skip to content

Commit

Permalink
Merge pull request #613 from praekelt/feature/search-query-trimming
Browse files Browse the repository at this point in the history
strip leading and trailing empty spaces in search query
  • Loading branch information
moh-moola committed Nov 28, 2018
2 parents 9c9ce58 + 38dbda9 commit 225003c
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
21 changes: 21 additions & 0 deletions molo/core/tests/test_search.py
Expand Up @@ -106,6 +106,27 @@ def test_search(self):
response = self.client.get(reverse('search'))
self.assertContains(response, 'No search results for None')

def test_search_empty_values(self):
self.backend = get_search_backend('default')
self.backend.reset_index()

self.mk_article(
self.english_section, title="Site 1 article")
self.mk_article(
self.yourmind2, title="Site 2 article")
self.backend.refresh_index()

response = self.client.get(reverse('search'), {
'q': ' '
})
self.assertEqual(response.status_code, 200)

response = self.client.get(reverse('search'), {
'q': ' article '
})
self.assertContains(response, 'Site 1 article')
self.assertNotContains(response, 'Site 2 article')

def test_search_works_with_multisite(self):
self.backend = get_search_backend('default')
self.backend.reset_index()
Expand Down
1 change: 1 addition & 0 deletions molo/core/views.py
Expand Up @@ -50,6 +50,7 @@ def csrf_failure(request, reason=""):

def search(request, results_per_page=10, load_more=False):
search_query = request.GET.get('q', None)
search_query = search_query.strip() if search_query else search_query
page = request.GET.get('p', 1)
locale = get_locale_code(get_language_from_request(request))

Expand Down

0 comments on commit 225003c

Please sign in to comment.