This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
Capture investigation referral data #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add redirect view to capture investigation UUID - add middleware to track user behaviour
nathanbegbie
force-pushed
the
feature/issue-162-capture-investigation-referral-data
branch
from
27de636
to
e28e4fb
Compare
Request and response objects are not JSON serializable, and a single DB write doesn't seem worth it to use Celery
nathanbegbie
force-pushed
the
feature/issue-162-capture-investigation-referral-data
branch
2 times, most recently
from
bd875e2
to
12737d2
Compare
rudigiesler
reviewed
May 28, 2018
analytics/models.py
Outdated
| method = models.TextField(null=True) | ||
| title = models.TextField(null=True) | ||
| visitor_uuid = models.TextField(null=True) | ||
| user_profile_uuid = models.TextField(null=True) |
There was a problem hiding this comment.
Should we have null=True for TextFields? We usually only want blank=True, so that we only have one way of representing a null value in the database.
analytics/middleware.py
Outdated
|
|
||
| visitor_uuid = request.COOKIES.get('visitor_uuid', False) | ||
| if not visitor_uuid: | ||
| response.set_cookie('visitor_uuid', str(uuid.uuid4())) |
There was a problem hiding this comment.
Just noting that we can also use the request session to store this UUID, or just use the session ID, instead of dealing with cookies ourselves.
| exclude = [p for p in settings.ANALYTICS_IGNORE_PATH | ||
| if request.path.startswith(p)] | ||
| return any(exclude) | ||
| return False |
There was a problem hiding this comment.
This will also include page views for people who didn't go through the analytics endpoint. Just want to make sure that that is the desired functionality.
There was a problem hiding this comment.
Yep, this was intended
nathanbegbie
force-pushed
the
feature/issue-162-capture-investigation-referral-data
branch
from
12737d2
to
afc7d0f
Compare
session ID is only recorded after this layer of middleware, hence the need for a new UUID
nurseconnect makes AJAX calls to menu on every page load for some reason request.is_ajax fails to pick this up in middleware
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.