Explicitly return zero if the unit cost is zero

praekeltfoundation · Feb 24, 2015 · 3e27932 · 3e27932
1 parent dd81d99
commit 3e27932
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/go/billing/tasks.py b/go/billing/tasks.py
@@ -172,7 +172,11 @@ def get_count(transaction):
 def get_session_length_count(transaction):
     length_cost = get_session_length_cost(transaction)
     unit_cost = get_session_length_unit_cost(transaction)
-    return length_cost / (unit_cost if unit_cost != 0 else 1)
+
+    if unit_cost == 0:
+        return Decimal(0)
+    else:
+        return length_cost / unit_cost
 
 
 def get_message_unit_cost(transaction):