Use a separate class level variable for the contact key to use as a l…

…ookup for subscription metrics
praekeltfoundation · Nov 12, 2013 · 8ce89e8 · 8ce89e8
1 parent d07691a
commit 8ce89e8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/go/apps/subscription/metrics.py b/go/apps/subscription/metrics.py
@@ -2,6 +2,8 @@
 
 
 class SubscriptionMetric(ConversationMetric):
+    CONTACT_LOOKUP_KEY = None
+
     def __init__(self, conv, campaign_name):
         self.campaign_name = campaign_name
         metric_name = self.make_metric_name(campaign_name)
@@ -15,14 +17,16 @@ def get_value(self, vumi_app, user_api):
         contacts = user_api.contact_store.contacts
         search = contacts.raw_search(
             "subscription-%s:%s" %
-            (self.campaign_name, self.METRIC_NAME))
+            (self.campaign_name, self.CONTACT_LOOKUP_KEY))
 
         return search.get_count()
 
 
 class SubscribedMetric(SubscriptionMetric):
     METRIC_NAME = 'subscribed'
+    CONTACT_LOOKUP_KEY = 'subscribed'
 
 
 class UnsubscribedMetric(SubscriptionMetric):
     METRIC_NAME = 'unsubscribed'
+    CONTACT_LOOKUP_KEY = 'unsubscribed'
diff --git a/go/apps/subscription/tests/test_metrics.py b/go/apps/subscription/tests/test_metrics.py
@@ -6,6 +6,7 @@
 
 class ToySubscriptionMetric(SubscriptionMetric):
     METRIC_NAME = 'toy-subscription-metric'
+    CONTACT_LOOKUP_KEY = 'toy-subscription-metric'
 
 
 class TestSubscriptionMetric(TxMetricTestBase):