Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Protect against errors in the sequential send polling looping call #1336

Merged
merged 3 commits into from Sep 21, 2015
Merged

Protect against errors in the sequential send polling looping call #1336

merged 3 commits into from Sep 21, 2015

Conversation

hodgestar
Copy link
Contributor

Currently any errors will cause the looping call to exit and sequential send to silently stop doing its job.

@hodgestar
Copy link
Contributor Author

Ready for review.

jerith
jerith reviewed Sep 18, 2015
View reviewed changes
go/apps/sequential_send/tests/test_vumi_app.py

patch.restore()

# no conversations processed initiall because of the error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"initially"

@jerith
Copy link
Member

jerith commented Sep 18, 2015

We should probably also wrap process_conversation_schedule so that a persistent error in one conversation doesn't block other conversations.

@hodgestar
Copy link
Contributor Author

Ready for re-review.

@jerith
Copy link
Member

jerith commented Sep 21, 2015

👍

@hodgestar hodgestar merged commit 38cf078 into develop Sep 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hodgestar @jerith