Better comments near hardcoded port numbers.

praekeltfoundation · Oct 31, 2013 · 355330a · 355330a
1 parent 071de72
commit 355330a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/vumi/transports/vas2nets/tests/test_failures.py b/vumi/transports/vas2nets/tests/test_failures.py
@@ -163,7 +163,8 @@ def test_send_sms_noconn(self):
         """
         A 'connection refused' error should be retried.
         """
-        # Hope nothing's listening on this port.
+        # TODO: Figure out a solution that doesn't require hoping that
+        #       nothing's listening on this port.
         self.worker.config['url'] = 'http://localhost:9999/'
 
         self.worker.failure_published = FailureCounter(1)

diff --git a/vumi/transports/vas2nets/tests/test_vas2nets.py b/vumi/transports/vas2nets/tests/test_vas2nets.py
@@ -291,7 +291,8 @@ def test_send_sms_fail(self):
 
     @inlineCallbacks
     def test_send_sms_noconn(self):
-        # Hope nothing's listening on this port.
+        # TODO: Figure out a solution that doesn't require hoping that
+        #       nothing's listening on this port.
         self.transport.config['url'] = 'http://localhost:9999/'
         msg = self.make_outbound("hello")
         d = self.dispatch(msg)