Avoid the use of getattr.

praekeltfoundation · Nov 23, 2015 · 58348fd · 58348fd
1 parent fdb454a
commit 58348fd
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/vumi/components/tests/test_message_store.py b/vumi/components/tests/test_message_store.py
@@ -113,8 +113,11 @@ def create_outbound_messages(self, batch_id, count, start_timestamp=None,
         returnValue(messages)
 
     def _create_event(self, event_type, timestamp):
-        assert event_type in ('ack', 'nack', 'delivery_report')
-        maker = getattr(self.msg_helper, 'make_%s' % (event_type,))
+        maker = {
+            'ack': self.msg_helper.make_ack,
+            'nack': self.msg_helper.make_nack,
+            'delivery_report': self.msg_helper.make_delivery_report,
+        }[event_type]
         return maker(timestamp=timestamp)
 
     @inlineCallbacks