Fix manhole middleware tests. #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This version passes tests locally for me on Twisted 16.0. Will need to see what happens with Twisted 13.2 in Travis. |
|
The tests are skipped for Twisted 13.2 on Travis as they always were and now pass on Twisted 16.0. Given that the tests were completely broken (on all Twisted versions before), these feels like it's already a major improvement. Ready for review. |
|
Tests now run & pass for Twisted 13.2 too. |
|
@rudigiesler @KaitCrawford Would you mind reviewing? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests suddenly run under Travis with Twisted 16.0 (yay!), but are very broken (eep!).