Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outbound character set handling in SMPP #332

Merged
merged 2 commits into from Oct 10, 2013
Merged

Outbound character set handling in SMPP #332

merged 2 commits into from Oct 10, 2013

Conversation

smn
Copy link
Member

@smn smn commented Oct 10, 2013

We handle assorted character sets for inbound messages, but we send UTF-8 for all outbound messages. We should do something about that.

@smn
Copy link
Member

smn commented Oct 12, 2012

If we specify the correct value in data_coding that corresponds with UTF-8 I don't see why this is a problem?

@jerith
Copy link
Member Author

jerith commented Oct 12, 2012

There isn't a data_coding for that. Most SMSCs seem to use latin1 as their "default alphabet". I'm not entirely sure what happens with the other data_coding specifiers.

@herihaja herihaja mentioned this pull request Jul 3, 2013
Closed
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a0636cf on feature/issue-332-outbound-char-sets into * on develop*.

@hodgestar
Copy link
Contributor

Needs a test but otherwise looks good.

@hodgestar
Copy link
Contributor

👍

@smn smn merged commit 435e093 into develop Oct 10, 2013
@jerith jerith deleted the feature/issue-332-outbound-char-sets branch April 4, 2014 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smn @jerith @coveralls @hodgestar