Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashes should be allowed in project names #59

Open
anasbarg opened this issue Nov 15, 2020 · 0 comments
Open

Dashes should be allowed in project names #59

anasbarg opened this issue Nov 15, 2020 · 0 comments
Labels
P2 Duh!

Comments

@anasbarg
Copy link
Collaborator

In Pragma v0.1.0 the projectName's value in a config can't contain a - like this:

config {
  projectName = "montaj-online"
}

Current behavior

In this case, Pragma will throw the following error:

[Error] The project's name must not contain any dashes ('-') : at line 2

  projectName = "montaj-online"
  ^^^^^^^^^^^

Now this is because the project name as the name of the PostgreSQL database in development mode, and database names in PostgreSQL can't contain dashes.

Expected behavior

Pragma shouldn't complain about this.

Suggested fix

The name of the database should be the name of the project between ": dbName = '"' + projectName + '"'. This will make PostgreSQL ignore the dash.

@anasbarg anasbarg added P2 Duh! bug Something isn't working labels Nov 19, 2020
@anasbarg anasbarg changed the title Dashes not allowed in project names Dashes should be allowed in project names Nov 24, 2020
@anasbarg anasbarg removed the bug Something isn't working label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Duh!
Projects
None yet
Development

No branches or pull requests

1 participant