fix(admin.gbapp): /publish can be called with no CUI.

GeneralBots · May 23, 2020 · a469d6d · a469d6d
1 parent 093e0a9
commit a469d6d
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/packages/admin.gbapp/dialogs/AdminDialog.ts b/packages/admin.gbapp/dialogs/AdminDialog.ts
@@ -179,7 +179,7 @@ export class AdminDialog extends IGBDialog {
 
             let from = step.context.activity.from.id;
 
-            let canPublish = AdminDialog.canPublish(min, from);              
+            let canPublish = AdminDialog.canPublish(min, from);
 
             if (canPublish) {
 
@@ -188,8 +188,9 @@ export class AdminDialog extends IGBDialog {
               await min.conversationalService.sendText(min, step, Messages[locale].working('Publishing'));
 
               step.activeDialog.state.options.args = (step.options as any).args;
-              let args = step.activeDialog.state.options.args.split(' ');
-              let filename = args[0];
+              const filename = step.activeDialog.state.options.args ?
+                step.activeDialog.state.options.args.split(' ')[0] : null;
+
               const packages = [];
               if (filename === null || filename === "") {
                 await min.conversationalService.sendText(min, step, `Starting publishing for ${botId}.gbkb...`);
@@ -206,15 +207,15 @@ export class AdminDialog extends IGBDialog {
                   const cmd1 = `deployPackage ${process.env.STORAGE_SITE} /${process.env.STORAGE_LIBRARY}/${botId}.gbai/${packageName}`;
 
                   if (await (deployer as any).getStoragePackageByName(min.instance.instanceId,
-                    packageName) !== null) { 
+                    packageName) !== null) {
                     const cmd2 = `undeployPackage ${packageName}`;
                     await GBAdminService.undeployPackageCommand(cmd2, min);
                   }
                   await GBAdminService.deployPackageCommand(min, cmd1, deployer);
                   await min.conversationalService.sendText(min, step, `Finished publishing ${packageName}.`);
                 });
               } catch (error) {
-                await min.conversationalService.sendText(min, step, `ERROR: ${error}` );
+                await min.conversationalService.sendText(min, step, `ERROR: ${error}`);
                 GBLog.error(error);
                 return await step.replaceDialog('/ask', { isReturning: true });
               }
@@ -251,7 +252,7 @@ export class AdminDialog extends IGBDialog {
     }
     return result;
   }
-  
+
   private static setupSecurityDialogs(min: GBMinInstance) {
     min.dialogs.add(
       new WaterfallDialog('/setupSecurity', [