Skip to content

Commit

Permalink
fix(VBA): Removal of invalid error messages.
Browse files Browse the repository at this point in the history
  • Loading branch information
rodrigorodriguez committed Dec 23, 2018
1 parent 6ba8c09 commit dd92032
Showing 1 changed file with 21 additions and 5 deletions.
26 changes: 21 additions & 5 deletions packages/core.gbapp/services/TSCompiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,18 @@ import * as ts from 'typescript';
const logger = require('../../../src/logger');

export class TSCompiler {


private static shouldIgnoreError(diagnostic) {
const message = ts.flattenDiagnosticMessageText(diagnostic.messageText, '\n');

if (message.indexOf('Cannot find name') >= 0 || message.indexOf('Cannot use imports') >= 0) {
return true;
}

return false;
}

public compile(
fileNames: string[],
options: ts.CompilerOptions = {
Expand All @@ -61,15 +73,19 @@ export class TSCompiler {
const allDiagnostics = ts.getPreEmitDiagnostics(program).concat(emitResult.diagnostics);

allDiagnostics.forEach(diagnostic => {
if (diagnostic.file) {
const { line, character } = diagnostic.file.getLineAndCharacterOfPosition(diagnostic.start!);
if (!TSCompiler.shouldIgnoreError(diagnostic)) {
const message = ts.flattenDiagnosticMessageText(diagnostic.messageText, '\n');
logger.error(`${diagnostic.file.fileName} (${line + 1},${character + 1}): ${message}`);
} else {
logger.error(`${ts.flattenDiagnosticMessageText(diagnostic.messageText, '\n')}`);

if (diagnostic.file) {
const { line, character } = diagnostic.file.getLineAndCharacterOfPosition(diagnostic.start);
logger.error(`${diagnostic.file.fileName} (${line + 1},${character + 1}): ${message}`);
} else {
logger.error(`${message}`);
}
}
});

return emitResult;
}

}

0 comments on commit dd92032

Please sign in to comment.