fix(kb.gbapp): Fix in subjects null pointer.

GeneralBots · May 1, 2019 · e21916f · e21916f
1 parent ef3c5a1
commit e21916f
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 4 deletions.
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -0,0 +1,19 @@
+{
+    // See https://go.microsoft.com/fwlink/?LinkId=733558 
+    // for the documentation about the tasks.json format
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "type": "typescript",
+            "tsconfig": "tsconfig.json",
+            "option": "watch",
+            "problemMatcher": [
+                "$tsc-watch"
+            ],
+            "group": {
+                "kind": "build",
+                "isDefault": true
+            }
+        }
+    ]
+}
diff --git a/packages/analytics.gblib/models/index.ts b/packages/analytics.gblib/models/index.ts
@@ -36,7 +36,6 @@
 
 'use strict';
 
-
 import {
   AutoIncrement,
   BelongsTo,

diff --git a/packages/azuredeployer.gbapp/services/AzureDeployerService.ts b/packages/azuredeployer.gbapp/services/AzureDeployerService.ts
@@ -486,7 +486,7 @@ export class AzureDeployerService implements IGBInstallationDeployer {
         } catch (error) {
           reject(error);
         }
-      }, 20000);
+      }, 60000);
     });
   }
 

diff --git a/packages/kb.gbapp/services/KBService.ts b/packages/kb.gbapp/services/KBService.ts
@@ -86,6 +86,7 @@ export class KBService {
 
   public static getSubjectItemsSeparatedBySpaces(subjects: GuaribasSubject[]) {
     const out = [];
+    if (subjects === undefined) { return ''; }
     subjects.forEach(subject => {
       out.push(subject.internalId);
     });
@@ -168,7 +169,7 @@ export class KBService {
         query = `${query} ${text}`;
       }
     }
-    query = `${query}&$filter=instanceId eq ${instance.instanceId}`;
+    // TODO: query = `${query}&$filter=instanceId eq ${instance.instanceId}`;
 
     // tslint:disable:no-unsafe-any
     if (instance.searchKey !== null && GBConfigService.get('STORAGE_DIALECT') === 'mssql') {

diff --git a/packages/security.gblib/models/index.ts b/packages/security.gblib/models/index.ts
@@ -36,7 +36,6 @@
 
 'use strict';
 
-
 import {
   AutoIncrement,
   BelongsTo,