Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding a new tag in SelectionMode #116

Merged
merged 1 commit into from Dec 6, 2016

Conversation

klacointe
Copy link
Contributor

Step to reproduce:

  • Run the npm run dev example with autocomplete={true} props
  • Type Ind and navigate in the suggestions without validate
  • Type additional characters to have no suggestions, ie Indy
  • Press enter
  • The new tag is not added

=> Uncaught TypeError: Cannot read property 'toLowerCase' of undefined

@klacointe
Copy link
Contributor Author

@prakhar1989 up?

@prakhar1989
Copy link
Collaborator

Heya @klacointe, so sorry - for some reason I completely missed this PR! I just reproduced the bug and your fix seems great.

Thanks for finding this and sending in the fix.

@prakhar1989 prakhar1989 merged commit 55d3920 into react-tags:master Dec 6, 2016
prakhar1989 added a commit that referenced this pull request Dec 6, 2016
@klacointe
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants