Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags header #98

Merged
merged 1 commit into from Sep 14, 2021
Merged

tags header #98

merged 1 commit into from Sep 14, 2021

Conversation

samvirg-git
Copy link
Contributor

hi @krishpranav check the thing I just added some auto constexpr for enum values
first pull request of me @samvirg-git
authors: @krishpranav, @samvirg-git

added some auto constexpr for enum values
first pull request of me @samvirg-git 
authors: @krishpranav, @samvirg-git
@krishpranav krishpranav added the enhancement New feature or request label Sep 14, 2021
@krishpranav
Copy link
Member

hey @samvirg-git great let me check the things you've added!!

@samvirg-git
Copy link
Contributor Author

hi @krishpranav hope you like the thing that I added I just added the constexpr auto values for the enum values I've added that willl be useful for other header files your going to create all around pranaOS! :)

@krishpranav
Copy link
Member

hi @krishpranav hope you like the thing that I added I just added the constexpr auto values for the enum values I've added that willl be useful for other header files your going to create all around pranaOS! :)

that's great @samvirg-git

@krishpranav
Copy link
Member

MERGED

@samvirg-git
Copy link
Contributor Author

thanks my first pr I am so happy!! :)

@krishpranav
Copy link
Member

;)

@krishpranav
Copy link
Member

pr's are always welcome ;)

@samvirg-git
Copy link
Contributor Author

thanks!!

@krishpranav krishpranav merged commit 40a637c into pranaOS:master Sep 14, 2021
@krishpranav krishpranav added this to Closed Pull Request in pranaOS PullRequests Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
2 participants