Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing <enter> refreshes the page when creating a room #182

Open
yashshah1 opened this issue Jul 22, 2020 · 1 comment · May be fixed by #184
Open

Pressing <enter> refreshes the page when creating a room #182

yashshah1 opened this issue Jul 22, 2020 · 1 comment · May be fixed by #184
Assignees
@naman-modi

Comments

@yashshah1
Copy link
Contributor

yashshah1 commented Jul 22, 2020 •
edited by naman-modi
Loading

STR:

  • Go to /
  • Click on create room
  • Type a room name
  • Press Enter

Ideal Behaviour:

  • Room gets created

Current Behaviour:

  • Page gets refreshed

Currently, the user is expected to click on Add when pressing the enter key should be enough to trigger a form submit.
@naman-modi
Copy link
Collaborator

Right, it is not as expected. Will look into it.

@naman-modi naman-modi self-assigned this Jul 27, 2020
@yashshah1 yashshah1 linked a pull request Jul 27, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naman-modi naman-modi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement: enter button now creates the room in modal
2 participants
@yashshah1 @naman-modi