Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Shouldn't require certs to be stored in filesystem #1

Closed
snej opened this issue May 30, 2013 · 1 comment
Closed

Shouldn't require certs to be stored in filesystem #1

snej opened this issue May 30, 2013 · 1 comment

Comments

@snej
Copy link

snej commented May 30, 2013

The Connect() function takes filesystem paths to the certificate and private key files. That's too limiting — the server may not have filesystem storage available, or the private key may be considered too sensitive so it might be kept in a Keychain-like store or an LDAP server.

Probably the most flexible way to do this would be for Connect() to take a tls.Certificate as a parameter, and let the caller load the certificate by calling either LoadX509KeyPair or X509KeyPair, the latter of which takes the components as raw byte arrays.

(I just filed the exact same issue as huo-ju/Go-Apns#3. Apologies for copying and pasting the text, but the issue with both packages is identical.)

@pranavraja
Copy link
Owner

Thanks for the feedback!

I've added apns.NewService in c7ffee5 which allows the caller to pass in a custom tls.Config. This would let you load in your own certificates, override the SSL verification behaviour, etc. For an example, see http://godoc.org/github.com/pranavraja/apns#NewService

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants