Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode support #30

Closed
fdemello opened this issue Sep 13, 2019 · 3 comments · Fixed by #58
Closed

Dark mode support #30

fdemello opened this issue Sep 13, 2019 · 3 comments · Fixed by #58
Assignees
Labels
feature request New feature request v3.0.0 Features/fixes to be added in v3.0.0

Comments

@fdemello
Copy link

Native dark mode support would be nice.

@praneshr
Copy link
Owner

It will be added in the next major version😃

@fdemello
Copy link
Author

fdemello commented Sep 13, 2019

@praneshr Awesome! In my implementation, I used these colors:

{
        variables: {
          diffViewerBackground: '#1e1e1f', 
          addedBackground: '#1e481e', 
          addedColor: 'white',
          removedBackground: '#511519', 
          removedColor: 'white', 
          wordAddedBackground: '#163616', 
          wordRemovedBackground: '#3c1013', 
          addedGutterBackground: '#1e4622', 
          removedGutterBackground: '#461216', 
          gutterBackground: '#202020', 
          gutterBackgroundDark: '#1a1a1a', 
          highlightBackground: '#fffbdd',
          highlightGutterBackground: '#fff5b1',
          codeFoldGutterBackground: '#57575b',
          codeFoldBackground: '#3e3e41',
          emptyLineBackground: '#1e1e1f',
        },
        line: {
          color: 'white',
        },
      }

I'm not sure if there's a standard for these or if you would want to have theme support like gitlab (https://gitlab.com/gitlab-org/gitlab-foss/tree/master/app/assets/stylesheets/highlight/themes)

@praneshr praneshr self-assigned this Oct 19, 2019
@praneshr praneshr added v3.0.0 Features/fixes to be added in v3.0.0 feature request New feature request labels Oct 19, 2019
@praneshr
Copy link
Owner

Hello! v3.0.0 beta is now available. This issue is addressed in this release. Try it out and provide feedback.

@praneshr praneshr mentioned this issue Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request v3.0.0 Features/fixes to be added in v3.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants