Some Bugs in New 2.5.3

[xololunatic]

1. First one is about Upload from URL. Not working totally clicked a lot of times. It is not showing the URL input box at ll

2. 2nd one is about Advanced Editor (which worked fine in 2.5.0 and 2.4.7 ) but now it's not working maybe because of an offline shift or something. I checked the console it currently shows this type of error GET "https://example.com/x/u/assets/js/theme-monokai.js" 404

3. 3rd one is about highlight.js which I already put in another issue. That time I was using 2.5.0 but now also in 2.5.3 it's not working at all but it's weird that it was working on localhost. So this issue could only be Mine maybe but please suggest something to fix that

4. 4th one is the MAJOR ISSUE. In 2.5.3 when logging in it should take us to the tfm.php file or (modified index.php) but when login is complete it's taking us to the website main URL. For example, if I have tfm in www.example.com/tfm/index.php (index.php is tfm) then after logging in it redirects to www.example.com and then I have to press back on the browser then it takes me to www.example.com/tfm/index.php

5th one was an issue with subfolder and download links but I think it's fixed in 2.5.4 I tried it SO its good to go.

I HOPE THESE GET FIXED SOON. IF I MADE ANY MISTAKE POSTING THIS/ THEN I APOLOGIZE AND I AM NEW TO THIS TFM. SO CUT ME SOME SLACK.

[mrihtar]

About the 4th issue: the solution would be to change redirection in lines 323 and 327 from
fm_redirect(FM_ROOT_URL);
to
fm_redirect(FM_SELF_URL);

Also, there's another issue in the latest offline version - supplied tinyfilemanager-2.5.3.zip, which can be downloaded from the Releases section, includes file assests/js/datatables.min.js, but the code references assests/js/dataTables.min.js (with a capital T).

[xololunatic]

Thanks for the reply. Literally everyone ghosted issues that I posted. Hope they will look into the matter. I think these are simple issues which can be solved easily instead of adding new features.

[ner00]

I think all these issues have been solved by now, no?
Personally, I never experienced 1, 2, or 3 - are you using the master branch version of the offline branch?

4. is definitely fixed: login (Redirecting to Main domain of website instead of tfm.php) fix #1031

[xololunatic]

@ner00 You are right they have been fixed but personally the 3rd one is still not working for me and i don't know why... I think everyone else's are working fine. I don't know what is the problem of highlight.js on my website (i think its becoz i have not implemented node.js for that but works when on localhost (local environment ) so maybe that's Why i really don't know...

[ner00]

For me that issue only happens if somehow the resource highlight.min.js fails to load.

Although, I can confirm that I too have this issue if the file language is HTML and the extension is .htm, this can be mapped here:

tinyfilemanager/tinyfilemanager.php

Lines 1812 to 1813 in f380478

	$hljs_classes = array(
	'shtml' => 'xml',

Mapp unsupported extension like so:

 $hljs_classes = array( 
     'htm' => 'html', 

An also, for the advanced editor:

tinyfilemanager/tinyfilemanager.php

Line 4174 in f380478

_data = {"aceTheme":{"bright":{"chrome":"Chrome","clouds":"Clouds","crimson_editor":"Crimson Editor","dawn":"Dawn","dreamweaver":"Dreamweaver","eclipse":"Eclipse","github":"GitHub","iplastic":"IPlastic","solarized_light":"Solarized Light","textmate":"TextMate","tomorrow":"Tomorrow","xcode":"XCode","kuroir":"Kuroir","katzenmilch":"KatzenMilch","sqlserver":"SQL Server"},"dark":{"ambiance":"Ambiance","chaos":"Chaos","clouds_midnight":"Clouds Midnight","dracula":"Dracula","cobalt":"Cobalt","gruvbox":"Gruvbox","gob":"Green on Black","idle_fingers":"idle Fingers","kr_theme":"krTheme","merbivore":"Merbivore","merbivore_soft":"Merbivore Soft","mono_industrial":"Mono Industrial","monokai":"Monokai","pastel_on_dark":"Pastel on dark","solarized_dark":"Solarized Dark","terminal":"Terminal","tomorrow_night":"Tomorrow Night","tomorrow_night_blue":"Tomorrow Night Blue","tomorrow_night_bright":"Tomorrow Night Bright","tomorrow_night_eighties":"Tomorrow Night 80s","twilight":"Twilight","vibrant_ink":"Vibrant Ink"}},"aceMode":{"javascript":"JavaScript","abap":"ABAP","abc":"ABC","actionscript":"ActionScript","ada":"ADA","apache_conf":"Apache Conf","asciidoc":"AsciiDoc","asl":"ASL","assembly_x86":"Assembly x86","autohotkey":"AutoHotKey","apex":"Apex","batchfile":"BatchFile","bro":"Bro","c_cpp":"C and C++","c9search":"C9Search","cirru":"Cirru","clojure":"Clojure","cobol":"Cobol","coffee":"CoffeeScript","coldfusion":"ColdFusion","csharp":"C#","csound_document":"Csound Document","csound_orchestra":"Csound","csound_score":"Csound Score","css":"CSS","curly":"Curly","d":"D","dart":"Dart","diff":"Diff","dockerfile":"Dockerfile","dot":"Dot","drools":"Drools","edifact":"Edifact","eiffel":"Eiffel","ejs":"EJS","elixir":"Elixir","elm":"Elm","erlang":"Erlang","forth":"Forth","fortran":"Fortran","fsharp":"FSharp","fsl":"FSL","ftl":"FreeMarker","gcode":"Gcode","gherkin":"Gherkin","gitignore":"Gitignore","glsl":"Glsl","gobstones":"Gobstones","golang":"Go","graphqlschema":"GraphQLSchema","groovy":"Groovy","haml":"HAML","handlebars":"Handlebars","haskell":"Haskell","haskell_cabal":"Haskell Cabal","haxe":"haXe","hjson":"Hjson","html":"HTML","html_elixir":"HTML (Elixir)","html_ruby":"HTML (Ruby)","ini":"INI","io":"Io","jack":"Jack","jade":"Jade","java":"Java","json":"JSON","jsoniq":"JSONiq","jsp":"JSP","jssm":"JSSM","jsx":"JSX","julia":"Julia","kotlin":"Kotlin","latex":"LaTeX","less":"LESS","liquid":"Liquid","lisp":"Lisp","livescript":"LiveScript","logiql":"LogiQL","lsl":"LSL","lua":"Lua","luapage":"LuaPage","lucene":"Lucene","makefile":"Makefile","markdown":"Markdown","mask":"Mask","matlab":"MATLAB","maze":"Maze","mel":"MEL","mixal":"MIXAL","mushcode":"MUSHCode","mysql":"MySQL","nix":"Nix","nsis":"NSIS","objectivec":"Objective-C","ocaml":"OCaml","pascal":"Pascal","perl":"Perl","perl6":"Perl 6","pgsql":"pgSQL","php_laravel_blade":"PHP (Blade Template)","php":"PHP","puppet":"Puppet","pig":"Pig","powershell":"Powershell","praat":"Praat","prolog":"Prolog","properties":"Properties","protobuf":"Protobuf","python":"Python","r":"R","razor":"Razor","rdoc":"RDoc","red":"Red","rhtml":"RHTML","rst":"RST","ruby":"Ruby","rust":"Rust","sass":"SASS","scad":"SCAD","scala":"Scala","scheme":"Scheme","scss":"SCSS","sh":"SH","sjs":"SJS","slim":"Slim","smarty":"Smarty","snippets":"snippets","soy_template":"Soy Template","space":"Space","sql":"SQL","sqlserver":"SQLServer","stylus":"Stylus","svg":"SVG","swift":"Swift","tcl":"Tcl","terraform":"Terraform","tex":"Tex","text":"Text","textile":"Textile","toml":"Toml","tsx":"TSX","twig":"Twig","typescript":"Typescript","vala":"Vala","vbscript":"VBScript","velocity":"Velocity","verilog":"Verilog","vhdl":"VHDL","visualforce":"Visualforce","wollok":"Wollok","xml":"XML","xquery":"XQuery","yaml":"YAML","django":"Django"},"fontSize":{8:8,10:10,11:11,12:12,13:13,14:14,15:15,16:16,17:17,18:18,20:20,22:22,24:24,26:26,30:30}};

You can add mapping here by adding to the list:

"htm":"HTML"

Although for me the advanced editor selects HTML automatically but doesn't highlight anything at all unless I manually toggle it.

[xololunatic]

@ner00 My advance editor works fine for all file types i have php, html and all others.. I only have problem with highlight.js .... Not only html but every type of file it doesn't apply highlight.js to any of my files.... I don't get it why.. i am using online version (I too thought that this could be a problem with resource offline one so i checked online one) what is interesting is if I use same tinyfilesmanager.php file on localhost (xampp) the highlight.js works.for every file I have but when I put the same tinyfilesmanager.php file to my website... The highlights.js does not work at all or on any kind of file. It is like it isn't present in the code at all.. I don't know if anyone can explain that... I am so confused that's why i am blaming my servers for that... Because I don't Know where the problem is..

[ner00]

Close this or change the title to be more specific.