Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking should show you the current build progress, not cancel the build. #11

Open
johnfn opened this issue Mar 27, 2017 · 4 comments
Open

Comments

@johnfn
Copy link

johnfn commented Mar 27, 2017

Hey @prashaantt! Gotta say, I love your plugin and I use it every day! 😁

The only thing that I think could be improved is that it would be really nice if clicking on the "Building..." label would simply show you the progress of the build (as clicking on "Passing" does), rather than canceling the build.

I find that I want to see the progress of the build much more often than I want to cancel the build.

The behavior for canceling the build could still be preserved. Perhaps there could be a small X icon to cancel the build that would show only while the build was, ah, building. 😄

Anyway, again this plugin is great. Simple and effective. Thanks for your work!

@prashaantt
Copy link
Owner

prashaantt commented Mar 29, 2017

I'm glad you find it useful.

Although it's not very uncommon to need to stop a build (when the build takes far too long or the process doesn't exit for some reason), what you say may be ideal from a UI perspective but it isn't currently possible to do in VS Code to show a status button with two actions. I suggest to manually open Output and choose "Node TDD" from the dropdown while the build is in progress.

@johnfn
Copy link
Author

johnfn commented Mar 31, 2017

I'm not sure I understand because it appears you already show two different buttons. One is the TDD with a rocketship and one is the "Passing/Build Stopped/Failing" button.

Since the TDD button always stops the whole process, couldn't its behavior be preserved, and the "Building" button could be made to show the current build?

@prashaantt
Copy link
Owner

It's not intuitive to use the disable TDD button as the exclusive way to stop the build, IMO — that's just a side-effect.

If I understand correctly, Code is apparently working to allow built-in visual feedback in extensions, perhaps like the one I had to do for the building animation. I will revisit the buttons then and see if it still makes sense to move things around as you expect.

@kbrandwijk
Copy link

You could maybe also show an extra little button with an eye icon just for the duration of the build to click on to open build progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants