Days Finder In A Month #451
Conversation
This Code is used to convert Celsius into Fahrenheit and vice versa.
Temperature Converter
There was a problem hiding this comment.
Changes to be done :
Changes your project title as "Days Finder In A Month"
All images and screenshots should be in "Images" folder
You had added a earlier PR project file temperature converter here. Add project files for this project.
There is no "README.md" file here.
Kindly addressed these changes. @Ashu-1309
Uploaded Wrong file
|
Okay I will do it |
Ashu-1309
changed the title
|
Do I have to upload temperature converter here also ??? |
|
It is not working properly can i closed this issue and start another one ??? |
Only upload the files related to your project. Your earlier project isn't needed here. @Ashu-1309 |
You should never close an issue or PR. Do changes asked for in your forked repository and repush your changes. @Ashu-1309 |
|
|
|
I am getting this error what should I do know ?? |
First thing this repo is ahead of your forked repo. Kindly make that even. For that in your forked repository, select fetch upstream and make it updated. Then do it again. @Ashu-1309 |
|
Now can you please check that is it okay ?? |
What's happening. You had again created new PR? What should I take into consideration. There is no need to create new PR's for each changes. Just do the changes in your forked repository and push it again. It would by default show up the changes here. @Ashu-1309 |
|
What should I do Now ??? |
You want guidance? @Ashu-1309 |
|
Yes please guide me . @prathimacode-hub |
Ok, I will back at 10. I shall guide you briefly along with the link on how to create PR easier. @Ashu-1309 |
|
Okay , what I have to do now, ?? Will I have to close the PR that was mistakenly create @prathimacode-hub |
You don't close PR's, that we shall look after. I shall revert back with a link. Wait. @Ashu-1309 |
Adding image to readme file
Change Program name from Days_finder to days_finder
|
What are the Changes now required can you please suggest me ??? |
There was a problem hiding this comment.
Changes to be done :
Add appropriate comments in code wherever necessary to get good understanding of the project.
In README.md file add the image link of the output screenshot you added up in "Image" folder. It should be the file path not user-images content. The thing you had added is not a link. Check it out.
Add imported library of your project in "requirements.txt" file.
Kindly do these changes. @Ashu-1309
Adding proper images in Readme file
Adding requirement file
|
I have done all the required changes . Can you please crosscheck it . |
There was a problem hiding this comment.
Changes to be done:
The requirements file should be titled as "requirements.txt"
In "README.md" file, the image link you added up is not a file path, it doesn't show up any visualization. Add the file path of the image present in "Images" folder. Don't add "user-images" content.
Add appropriate comments in your code wherever necessary to get good understanding of the project.
Kindly do these changes. @Ashu-1309
Changing the file path
Changing the name
Adding comment along with some changes in code .
Update photo after changes in code
Changes in image
|
All the required changes are done . |
There was a problem hiding this comment.
Whoaaa, congrats. Your PR is approved. Good initiation and dedication. Keep growing. Well done. 🎊👌✨@Ashu-1309
|
Thank You 😁😁 @prathimacode-hub |
prathimacode-hub
added
🟩 Level1
Related Issue
-Days Finder In A Month
Closes: #436
Describe the changes you've made
This is used to find the number of days in a month.
Type of change
What sort of change have you made:
How Has This Been Tested?
I tested the code in Online python compiler as well as in offline compiler.
Checklist: