Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Verification Added #42

Merged
merged 3 commits into from Mar 21, 2021
Merged

Conversation

SamarpanCoder2002
Copy link
Contributor

@SamarpanCoder2002 SamarpanCoder2002 commented Mar 21, 2021

Description :

  1. Email Verification Added.
  2. After Sign-up user Navigate to log-in page and after email verification user can navigate to the home page.

Fixes #38 :

Replace #38 with the issue number which is fixed in this PR

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change :

Please delete/edit options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist :

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

If this pull request ok, please review and merge it..... Thanks @pratyushmp

Copy link
Owner

@pratyushmp pratyushmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • After the user signs up, instead of showing the user a dialogue box saying Proceed with login. It would be better if it informed that a verification email is sent to your registered email id. Verify and Proceed to login.
  • Could you add the padding to the "Hello There ." text in the login screen so that it matches the UI in the readme.

@SamarpanCoder2002
Copy link
Contributor Author

  • After the user signs up, instead of showing the user a dialogue box saying Proceed with login. It would be better if it informed that a verification email is sent to your registered email id. Verify and Proceed to login.
  • Could you add the padding to the "Hello There ." text in the login screen so that it matches the UI in the readme.

Paddding there means some spaces from uppersie of that text to look good right just like README.....????? I will make changes within an hour....thanks @pratyushmp

lib/sign_up.dart Outdated
@@ -250,7 +250,7 @@ class SignUpScreenState extends State<SignUpScreen> {
style: TextStyle(color: Colors.white),
),
content: Text(
"Please Log-In To Continue",
"Verification Link Send to Your Registered Mail\nPlease Verify and Log-In",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "Send" to "Sent".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@SamarpanCoder2002
Copy link
Contributor Author

SamarpanCoder2002 commented Mar 21, 2021

  • After the user signs up, instead of showing the user a dialogue box saying Proceed with login. It would be better if it informed that a verification email is sent to your registered email id. Verify and Proceed to login.
  • Could you add the padding to the "Hello There ." text in the login screen so that it matches the UI in the readme.

Already Made changes..... please check it @pratyushmp

Hope you review it and merge it @pratyushmp @infiniteoverflow @nirala96

@pratyushmp pratyushmp merged commit 1fc8d86 into pratyushmp:main Mar 21, 2021
@pratyushmp
Copy link
Owner

Good Job @SamarpanCoder2002 .

@SamarpanCoder2002
Copy link
Contributor Author

Good Job @SamarpanCoder2002 .

Thank u @pratyushmp ... I requested in other issue about adding profile picture.....kindly check this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Email Verification for new users using Firebase
2 participants