Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 68 #79

Merged
merged 13 commits into from Apr 29, 2021
Merged

Issue 68 #79

merged 13 commits into from Apr 29, 2021

Conversation

Borahb
Copy link
Contributor

@Borahb Borahb commented Apr 26, 2021

Description :

Added Navigation for first-time users to user details screen and store data in firestore.

Fixes #68

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change :

Please delete/edit options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist :

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@SapinderSingh
Copy link
Contributor

SapinderSingh commented Apr 26, 2021

@Borahb Why did you edited the create goal page ? And, why did you changed the inital route from auth wrapper to login screen ?

@Borahb
Copy link
Contributor Author

Borahb commented Apr 26, 2021

@SapinderSingh Because it was showing a problem, so I thought of removing it.

@Borahb
Copy link
Contributor Author

Borahb commented Apr 26, 2021

@SapinderSingh Thanks for showing up the change in initial route part. I made the necessary changes.

@SapinderSingh
Copy link
Contributor

SapinderSingh commented Apr 27, 2021

@SapinderSingh Thanks for showing up the change in initial route part. I made the necessary changes.

you should also restore changes in create goal page, because getting the month with year is the required behavior

@Borahb
Copy link
Contributor Author

Borahb commented Apr 27, 2021

@SapinderSingh Okay, made the changes.

@pratyushmp pratyushmp merged commit 662b20a into pratyushmp:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigate First Time users to user_details_screen.dart and store the details in firebase
4 participants