Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collector to PravegaDeserializationSchema #530

Closed
crazyzhou opened this issue Jun 15, 2021 · 0 comments · Fixed by #533
Closed

Add collector to PravegaDeserializationSchema #530

crazyzhou opened this issue Jun 15, 2021 · 0 comments · Fixed by #533

Comments

@crazyzhou
Copy link
Contributor

Problem description
In FLIP-124, Flink has added the open/close method and included the collector in the deserialization schema to support more cases. We have covered the open in #519 , and we need to add the collector as well to fully adapt the new API.

This also helps to support the debezium format because it requires to call the method with a collector (ref: https://github.com/apache/flink/blob/1635f9326c8993114d8a5aa1881c2078393f8eb5/flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/debezium/DebeziumJsonDeserializationSchema.java#L119)

Problem location
reader, table API and serialization

Suggestions for an improvement
ref: https://github.com/apache/flink/pull/12018/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant