Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtendedS3StorageConfig does not handle missing trailing / in root #4412

Closed
sachin-j-joshi opened this issue Dec 2, 2019 · 0 comments · Fixed by #4413
Closed

ExtendedS3StorageConfig does not handle missing trailing / in root #4412

sachin-j-joshi opened this issue Dec 2, 2019 · 0 comments · Fixed by #4413
Assignees
Labels

Comments

@sachin-j-joshi
Copy link
Contributor

sachin-j-joshi commented Dec 2, 2019

Problem description
Current logic in ExtendedS3StorageConfig incorrectly assumes that root has a trailing '/' character. If this is not the case then the S3 storage is wrongly initialized and results in invalid paths/urls.

Problem location
ExtendedS3StorageConfig.java constructor where we initialize values from TypedProperties.

Suggestions for an improvement
Correctly handle the case, by adding the / char when it is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant