Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wake early in response to data arriving on another segment #4578

Closed
tkaitchuck opened this issue Feb 27, 2020 · 1 comment
Closed

Wake early in response to data arriving on another segment #4578

tkaitchuck opened this issue Feb 27, 2020 · 1 comment
Assignees
@tkaitchuck

Comments

@tkaitchuck
Copy link
Member

Problem description
When a reader is blocked waiting on a reply from the server it should be able to unblock and switch to another segment in the event that data arrives from the server.

This was previously implemented but it caused problems see: #4082

Problem location
EventStreamReaderImpl

Suggestions for an improvement
Add a variation on select so that we don't have to wait for the next iteration before selecting a new segment. Previously this caused problems with the CompletableFuture stack in Java 8 which had a bug.
#4056
This form of solution should be avoided.
@tkaitchuck tkaitchuck self-assigned this Feb 27, 2020
@shrids
Copy link
Contributor

shrids commented Feb 28, 2020

#4579 fixes this .

@shrids shrids closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkaitchuck tkaitchuck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkaitchuck @shrids