Renaming the site_name parameter

[PythonCoderAS]

Describe the solution you'd like

The name site_name is not representative of the different sections of a config file. It seems to represent alternate reddit sites.

I propose renaming site_name to something more descriptive, like section_name, or config_section_name, although the second one is a bit wordy.

[jarhill0]

Assuming you mean this.

As covered in documentation of praw.ini, the file allows you to actually configure PRAW to connect to some other instance of Reddit (such as if someone ran the archived open-source version) or access it through a different URL. While this use-case may not be common, it means that the site_name parameter can indeed be used to select an "alternate reddit site."

ConfigParser uses the name section, which may be more appropriate in general than site_name, especially considering that praw.ini files are, for the most part, used for configuring authentication information.

On balance, however, I think that the impact of the breaking change of renaming an argument in the initializer of the main class of this entire project is not worth the benefit of having a slightly nicer name.

[PythonCoderAS]

@bboe Can I get your opinion on this? I think we can introduce the change in PRAW 8.0, as this release already has way too many breaking changes.

[bboe]

I'm okay with this change assuming there is a deprecation period first.

[PythonCoderAS]

I'll introduce the deprecation period in 7.0, and remove in 8.0.

[bboe]

Author no longer active on this project :'(. Closing author's issues.