Api exception improvement #1485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboe
reviewed
May 5, 2020
| ) -> List[RedditErrorItem]: | ||
| """Covert an exception list into a :class:`.RedditErrorItem` list. | ||
|
|
||
| .. warning:: This method is deprecated. Use the private method of the |
There was a problem hiding this comment.
I don't think we should recommend using the private method. We could instead say something like this method is deprecated and will be removed without replacement in PRAW 8.0.
| @@ -81,6 +142,33 @@ def parse_exception_list( | |||
| ) | |||
| for exception in exceptions | |||
| ] | |||
| for exception in baselist: | |||
There was a problem hiding this comment.
Instead of this flag to differentiate between different cases of RedditErrorItem could we instead use different classes with the same interface?
There was a problem hiding this comment.
I don’t see the need to use different classes, as the only difference is the __repr__ method.
|
Author no longer active on this project :'(. Closing PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation changes to APIException and related items have been separated from the other PR.
Fix #1484