Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login does not raise error if invalid credentials are presented. #31

Closed
twoolie opened this issue Oct 3, 2011 · 4 comments
Closed

Login does not raise error if invalid credentials are presented. #31

twoolie opened this issue Oct 3, 2011 · 4 comments
Assignees

Comments

@twoolie
Copy link

twoolie commented Oct 3, 2011

calling reddit.login() does not give any indication if the credentials are incorrect. worse, it populates. the reddit.user field with a correct Redditor object, so there is no way to tell if login failed.

@nemec
Copy link
Contributor

nemec commented Oct 23, 2011

Still not entirely sure how to make pull requests for others' issues, but I've updated the code to check for RATELIMIT and WRONG_PASSWORD errors in the login response and raise Exceptions if they're encountered here: https://github.com/mellort/reddit_api/pull/27

@twoolie
Copy link
Author

twoolie commented Oct 25, 2011

i believe you just add mellort/reddit_api#31 to the description

@bboe
Copy link
Member

bboe commented Nov 30, 2011

I have a fix for this on my branch which handles the errors in a more user friendly manor. Unfortunately the fix has broken a few other things, so until I have tests for everything I wont be merging in this change.

@ghost ghost assigned bboe Nov 30, 2011
@bboe
Copy link
Member

bboe commented Dec 1, 2011

This is fixed in a nice way now.

@bboe bboe closed this as completed Dec 1, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants