-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFW issues #66
Comments
I'll take a look at this over the weekend. |
@marblar cool. What's the python 3 status? Should I start to integrate it? |
@bboe It's getting there. I have a bug or two to sort out, and then I want to do some clean up before we start integrating. If you want to take a look at the current state and make sure I'm headed in the right direction, you're welcome to. |
I was able to iterate through /r/nsfw without modification. Do you have any code to recreate the issue? |
Well it seems like it is not a problem for a non-authenticated user. However, if you provide a user, the user must have the over18 setting enabled. We should raise a ClientException when the 403 restricted error occurs (if that's the only case of that error and it's the right one). |
So there are some inconsistencies in the API with respect to the over18 setting. These being:
After a brief chat with @spladug it seems ignoring the NSFW setting for API users is the simplest route to take, compared to the alternative which is to add an API error for attempting to access NSFW content when over18 is not enabled. Waiting on reddit-archive/reddit#402 to go through. |
NSFW is no longer an issue for the API. reddit-archive/reddit@07d8675 |
There are two issues:
Ideally we will provide a method for obtaining the over18 cookie and either automatically perform this when an over18 exception is raised (if possible) or prompt the user for action.
The text was updated successfully, but these errors were encountered: