Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: approved_by/removed_by support #79

Closed
roger- opened this issue Mar 26, 2012 · 5 comments
Closed

Request: approved_by/removed_by support #79

roger- opened this issue Mar 26, 2012 · 5 comments

Comments

@roger-
Copy link

roger- commented Mar 26, 2012

Looks like Reddit recently added this to the JSON.

@bboe
Copy link
Member

bboe commented Apr 2, 2012

These fields are now valid redditor objects as of 1c49c5c. Note removed_by is not a field, it is banned_by.

@bboe bboe closed this as completed Apr 2, 2012
@roger-
Copy link
Author

roger- commented Apr 2, 2012

What about for Submission objects?

Mods have the ability to tell who removed/approved a post.

@bboe
Copy link
Member

bboe commented Apr 2, 2012

approved_by and banned_by are fields on Submission objects. If there is something I'm missing you need to be more explicit about where it appears.

@roger-
Copy link
Author

roger- commented Apr 2, 2012

Ah, must have missed them.

BTW, r.get_submission(submission_id=xyz).approved_by seems to be returning NoneType, as does .banned_by''', even though I'm logged in and know that particular post was approved (with.approve()``` call which I manually verified).

@bboe
Copy link
Member

bboe commented Apr 2, 2012

Regarding your last issue, that may be a bug on reddit's end. If the attributes aren't sent when directly obtaining a submission then there is no way the API can obtain them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants