Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movies not playing on linux #4

Closed
jjgalvez opened this issue Apr 29, 2022 · 2 comments
Closed

movies not playing on linux #4

jjgalvez opened this issue Apr 29, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jjgalvez
Copy link

First really cool project, at the moment I'm watching and occasionally building /testing it, so this is just a bug report, do what you want with it, and happy to test on linux if its helpful.

  1. when I try to watch a movie, it loads the background images and does nothing. when I kill the movie I get an error that says the browser does not support playing this movie. If I load the server in a browser the movies plays as expected.
  2. when you kill the server.py process with os.kill you are passing "0" which does not kill the process, I would suggest importing signal and either passing signal.SIGTERM, rather than 0.

Also you are using the default 5000 port for flask, I would suggest picking a random open port although honestly I have no idea how you would pass that to your webengineview url dynamically, so this may not be a helpful suggestion.

Either way cool project keep up the great work

@prayag17
Copy link
Owner

  1. The player can't yet play movies but I am working in it
  2. singnal.SIGTERM for some reason didn't kill the process on windows that is why for now I am using 0 but that also going to be fixed

@prayag17 prayag17 self-assigned this Apr 30, 2022
@prayag17 prayag17 added the enhancement New feature or request label Apr 30, 2022
@jjgalvez
Copy link
Author

  1. The player can't yet play movies but I am working in it
  2. singnal.SIGTERM for some reason didn't kill the process on windows that is why for now I am using 0 but that also going to be fixed

makes sense, I don't think SIGTERM is a thing on windows, you might have to check the os first and then use either 0 or SIGTERM

@prayag17 prayag17 added this to the Media playback milestone Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants