Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does loop use OverLapNet? #35

Closed
hitbg-yjm opened this issue Dec 22, 2020 · 2 comments
Closed

Does loop use OverLapNet? #35

hitbg-yjm opened this issue Dec 22, 2020 · 2 comments

Comments

@hitbg-yjm
Copy link

hitbg-yjm commented Dec 22, 2020

Thanks for your great work. In PRBonn/OverlapNet , it point out that OverLapNet used in suma++, but I don't find OverLapNet using in SurfelMapping::checkLoopClosure(). It seems to loop according to residual.

@hitbg-yjm hitbg-yjm changed the title Does loop use overlap? Does loop use OverLapNet? Dec 22, 2020
@Chen-Xieyuanli
Copy link
Member

Hey @hitbg-yjm,

Thanks for following our work!

To keep both repos standalone, we currently have no plan to release the joint part. SuMa++ therefore still uses the distance-based method for finding loops. But you could easily try to combine them by easily modifying the SurfelMapping::checkLoopClosure() to use the results from OverlapNet instead of distances.

I hope my answer helps!

@hitbg-yjm
Copy link
Author

Thank you for your reply. It makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants