Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable submodules checkout #43

Closed
nijel opened this issue Feb 9, 2021 · 3 comments
Closed

Add option to disable submodules checkout #43

nijel opened this issue Feb 9, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@nijel
Copy link

nijel commented Feb 9, 2021

Right now pre-commit-ci seems to checkout all submodules. This can fail or just slow down the build and it would be useful to turn this off in case it's not needed.

I've run into this in https://results.pre-commit.ci/run/github/116816146/1612858774.myIqOmUUTmGB06u0oFig9w where the submodules update fails (what might be a separate issue).

When I try it locally with git submodule update --init --recursive it works, but it takes quite long and there is no need to run this on pre-commit.ci as the submodules are neither supposed to be checked nor are needed for the pre-commit checks.

@nijel
Copy link
Author

nijel commented Feb 9, 2021

Having something similar as GitHub checkout action has would do that - set submodules to false / true / recursive would work. They have default to not checkout submodules, maybe it would be reasonable default for pre-commit.ci as well to avoid needlessly cloning submodules unless the user wants them.

@asottile asottile added bug Something isn't working enhancement New feature or request labels Feb 9, 2021
@asottile
Copy link
Member

I've split the bug portion to #44

@asottile asottile removed the bug Something isn't working label Feb 10, 2021
@asottile
Copy link
Member

submodules are now disabled by default and opt-in: https://pre-commit.ci/#configuration-submodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants