Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated schema on JSONSchema store #50

Closed
ad-m opened this issue Apr 4, 2021 · 2 comments
Closed

Outdated schema on JSONSchema store #50

ad-m opened this issue Apr 4, 2021 · 2 comments

Comments

@ad-m
Copy link

ad-m commented Apr 4, 2021

Hello,

Schema available at https://json.schemastore.org/pre-commit-config.json is outdated. It does not cover ci section at all.

I don't have knowledge about ci to fix that. I was looking for schema to get that knowledge.

Kind regards,

@asottile
Copy link
Member

asottile commented Apr 4, 2021

I am not affiliated with that schema source -- you should not trust it for correctness -- I would not recommend using it.

If you want validation, it is available in the following canonical places:

via pre-commit (pypi:

  • pre-commit-validate-config - validates a .pre-commit-config.yaml
  • pre-commit-validate-manifest - validates a .pre-commit-hooks.yaml

via pre-commit-ci-config (pypi):

  • check-pre-commit-ci-config - validates the ci section of a .pre-commit-config.yaml

@asottile asottile closed this as completed Apr 4, 2021
@asottile
Copy link
Member

asottile commented Apr 4, 2021

it's also incorrect for several other reasons (top-level variability, type checking, choices, etc.) that aren't representable in json schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants