You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Firstly, great service, this tool is a great help keeping code in check. One little irritation however, the bot seems to always choose the latest version of each hook, even when that version is incompatible with the project.
Our project targets multiple versions of Python, including some that are no longer maintained such as Python 3.6… just because 3.12 is the latest does not mean every computer with Python installed magically updates itself and some production environment are very conservative regarding updates.
(I've had to argue with a manager about Python 2.7 for example, and I have colleagues that still happily load Debian Stretch onto new boxes despite it being ancient today.)
As such, we try to limit ourselves to features supported by Python 3.6, chosen as a lower practical limit that still supports 'modern' features, whilst still allowing a wide compatibility base.
The problem is the pre-commit bot insists on bumping ruff-pre-commit. The last version to support Python 3.6 is v0.0.233. When it bumps this and proposes a pull request, the PR tests fail because… surprise surprise… the version of ruff used doesn't support this version of Python.
I had a look through the documentation and issues, couldn't see anywhere to "pin" a hook version. Is there a method to pin this particular hook to a compatible version?
Hi,
Firstly, great service, this tool is a great help keeping code in check. One little irritation however, the bot seems to always choose the latest version of each hook, even when that version is incompatible with the project.
Our project targets multiple versions of Python, including some that are no longer maintained such as Python 3.6… just because 3.12 is the latest does not mean every computer with Python installed magically updates itself and some production environment are very conservative regarding updates.
(I've had to argue with a manager about Python 2.7 for example, and I have colleagues that still happily load Debian Stretch onto new boxes despite it being ancient today.)
As such, we try to limit ourselves to features supported by Python 3.6, chosen as a lower practical limit that still supports 'modern' features, whilst still allowing a wide compatibility base.
The problem is the pre-commit bot insists on bumping
ruff-pre-commit
. The last version to support Python 3.6 is v0.0.233. When it bumps this and proposes a pull request, the PR tests fail because… surprise surprise… the version ofruff
used doesn't support this version of Python.https://results.pre-commit.ci/run/github/659078614/1697485172.NGow0yyXQNaO8Fti5MGycw
diazona/setuptools-pyproject-migration#108 is an example, where I've then had to revert one of the version bumps.
I had a look through the documentation and issues, couldn't see anywhere to "pin" a hook version. Is there a method to pin this particular hook to a compatible version?
(Previously raised pre-commit/pre-commit.com#887)
The text was updated successfully, but these errors were encountered: