Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add annotations to PR for hook failures #70

Closed
ddelange opened this issue Dec 18, 2020 · 1 comment
Closed

[feature] Add annotations to PR for hook failures #70

ddelange opened this issue Dec 18, 2020 · 1 comment

Comments

@ddelange
Copy link

ddelange commented Dec 18, 2020

Annotations from pre-commit errors showing up on the specific lines in the PR diff (e.g. EOF fixer, or flake8 https://github.com/TrueBrain/actions-flake8, pytest https://github.com/utgwkk/pytest-github-actions-annotate-failures) would be very beneficial for developers quickly spotting issues with their code :)

Example annotations:

@asottile
Copy link
Member

it runs arbitrary tools which produce arbitrary output -- there's no structured data

you could filter the output to generate the proper ::warning output command but that would need to happen somewhere else

writing to the actual checks-annotations endpoint requires a token as well, which isn't feasible

also development on the github action has ~mostly stopped -- I'd recommend using https://pre-commit.ci instead

additionally I find these check annotations to be incredibly annoying, they don't provide value in my opinion and instead make it much harder to read the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants