trailing-whitespace: add option for custom chars to strip #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Oct 25, 2019
|
this has been released in v2.4.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to the
trailing-whitespacehook,--chars, which allows you to specify a custom set of characters to pass torstrip.This flag was motivated by Common Lisp, in which a common convention is to use
\fto delineate sections of code.trailing-whitespaceconsiders these by default whitespace, and so strips out the section delimiters users want to preserve. In repositories where this convention is used, a custom value for--charscan be specified. This hook is general enough to be used in other use cases if need be, however.