Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction: Please add "4. (optional) Run against a single file" #445

Closed
guettli opened this issue Jan 8, 2021 · 1 comment
Closed

Comments

@guettli
Copy link

guettli commented Jan 8, 2021

At the moment there is this heading on the start-page:

  1. (optional) Run against all the files

I think running it against all files is too much at the beginning.

Why not like this?

4. (optional) Run against one file

5. (optional) Run against all the files

I think this would improve the first-time-user-experience.

Thank you for this great tool!

@asottile asottile transferred this issue from pre-commit/pre-commit Jan 8, 2021
@asottile
Copy link
Member

asottile commented Jan 8, 2021

I think running it against all files is too much at the beginning.

why? the operations are non-destructive, you can always git checkout -- . if they do not go according to plan

Why not like this?

generally fewer steps is better for a quick start, the step is optional as well, and then you'd have to explain why duplicate steps

I think this would improve the first-time-user-experience.

I disagree with this being an improvement, I think it'd make it more work to get started


thanks for the feedback, but I'm going to decline this suggestion

@asottile asottile closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants