Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook fail_fast stops pre-commit if any prior hook fails #945

Closed
tp832944 opened this issue Mar 21, 2024 · 2 comments
Closed

Hook fail_fast stops pre-commit if any prior hook fails #945

tp832944 opened this issue Mar 21, 2024 · 2 comments

Comments

@tp832944
Copy link

Hook fail_fast says in the documentation that pre-commit will stop if this hook fails, which suggests it is referring only to the present hook. After testing on pre-commit v3.6.2, the actual behaviour appears to be that pre-commit will stop if this or any previous hook fails.

I find the actual behaviour quite useful, as it means we can avoid running a slow hook (e.g. pytest) if any other hook has failed. Thus, my suggestion is to edit the documentation.

@asottile
Copy link
Member

this is not the intended behavior, perhaps an oversight in implementation

@tp832944
Copy link
Author

In which case, I have submitted a bug report instead.

@tp832944 tp832944 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants