Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tags as well as shas #106

Closed
asottile opened this issue Jun 7, 2014 · 4 comments
Closed

Support tags as well as shas #106

asottile opened this issue Jun 7, 2014 · 4 comments
Labels

Comments

@asottile
Copy link
Member

asottile commented Jun 7, 2014

They kind-of work as-is unless tags collide across different hooks.

The simplest solution is to make the repository symlinks repo + ref instead of just ref as they are right now.

Then anything that git understands as git checkout {0} will work.

@asottile
Copy link
Member Author

This is my start on this branch: https://github.com/pre-commit/pre-commit/tree/allow_tags

I don't think repo + ref is going to work because slashes, but maybe a hash of that will work.

@asottile
Copy link
Member Author

Partially implemented with #127

Need to add ref and deprecate sha.

Probably should add some additional logic for tags into autoupdate. Should be reasonably easy to do a natural sort on tags and bump to the latest tag (instead of reverting back to shas). At the very least it should not bump a tag to a sha.

@asottile
Copy link
Member Author

asottile commented Jun 4, 2017

The autoupdate work was done here via:

All that's left is to support ref and deprecate sha

@asottile
Copy link
Member Author

asottile commented Mar 4, 2018

This has been released as part of v1.7.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant