Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add ci testing on centos-7 platform #1213

Closed
ssbarnea opened this issue Nov 7, 2019 · 1 comment
Closed

feature: add ci testing on centos-7 platform #1213

ssbarnea opened this issue Nov 7, 2019 · 1 comment

Comments

@ssbarnea
Copy link

ssbarnea commented Nov 7, 2019

As I recently faced two bugs related to the older git version that comes with centos-7, I would like to propose to add a CI test that runs pre-commit on centos-7, so we can avoid future regressions.

This testing can be implemented using a container, maybe even using tox-docker and should include at least two tests that we already know to fail:

Is this ok? If so, what path would you recommend? I can easily make a PR to enable that.

@asottile
Copy link
Member

asottile commented Nov 7, 2019

no thanks, centos 7 is very old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants