Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sw-debug.js is included in build output when building with option --no-sw #1477

Closed
RonnyLV opened this issue Dec 1, 2020 · 1 comment · Fixed by #1478
Closed

sw-debug.js is included in build output when building with option --no-sw #1477

RonnyLV opened this issue Dec 1, 2020 · 1 comment · Fixed by #1478

Comments

@RonnyLV
Copy link

RonnyLV commented Dec 1, 2020

Do you want to request a feature or report a bug?
Bug

What is the current behaviour?
sw-debug.js is included in build output when building with option --no-sw

If the current behaviour is a bug, please provide the steps to reproduce.
image

What is the expected behaviour?
No sw-debug.js in build output with --no-sw enabled

Environment Info:
  System:
    OS: Linux 5.4 Alpine Linux
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  Binaries:
    Node: 14.15.1 - /usr/local/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.8 - /usr/local/bin/npm
  npmPackages:
    preact: ^10.3.1 => 10.5.7 
    preact-cli: 3.0.3 => 3.0.3 
    preact-render-to-string: ^5.1.4 => 5.1.12 
  npmGlobalPackages:
    preact-cli: 3.0.3
@rschristian
Copy link
Member

rschristian commented Dec 2, 2020

The SW will be copied to the output directory but won't be registered.

We can probably exclude it but there would be no change in functionality.

I'll look at writing something up to keep it out, but in the meantime, just add && rm build/sw-debug.js if you really don't want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants