Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Fix Chrome 88 stack traces displayed wrong in terminal #3008

Merged
merged 2 commits into from
Feb 13, 2021
Merged

Tests: Fix Chrome 88 stack traces displayed wrong in terminal #3008

merged 2 commits into from
Feb 13, 2021

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Feb 13, 2021 •
edited

Starting with Chrome 88 the stack trace format has changed a bit. The new version of errorstacks adds support for parsing that.

Before:

Screenshot 2021-02-13 at 08 50 57

After:

Screenshot 2021-02-13 at 08 50 48

@coveralls
Copy link

coveralls commented Feb 13, 2021 •
edited

Coverage Status

Coverage remained the same at 99.445% when pulling f99902d on karma-stack-traces into dcdc32a on master.

andrewiggins
andrewiggins approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marvinhagemeister marvinhagemeister merged commit 6c263a8 into master Feb 13, 2021
@marvinhagemeister marvinhagemeister deleted the karma-stack-traces branch February 13, 2021 18:06
This was referenced Mar 15, 2021
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced Mar 15, 2021
Open
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewiggins andrewiggins andrewiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinhagemeister @coveralls @andrewiggins